debootstrap: manpage neglects complete path for

[Hideki Yamane]

--unpack-tarball
Message-Id: <***@iijmio-mail.jp>
In-Reply-To: <***@iijmio-mail.jp>
X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hi list,

Could you review below messages in deboostrap manpage, please?

Here's a proposed patch for it.
diff --git a/debootstrap b/debootstrap
index 083473d..1d5d5c6 100755
--- a/debootstrap
+++ b/debootstrap
@@ -550,7 +550,7 @@ fi
if [ "$UNPACK_TARBALL" ]; then
if [ "${UNPACK_TARBALL#/}" = "$UNPACK_TARBALL" ]; then
- error 1 TARPATH "Tarball must be given a complete path"
+ error 1 TARPATH "Tarball must be given an absolute path"
fi
if [ "${UNPACK_TARBALL%.tar}" != "$UNPACK_TARBALL" ]; then
(cd "$TARGET" && tar -xf "$UNPACK_TARBALL")
diff --git a/debootstrap.8 b/debootstrap.8
index e802003..699f1fd 100644
--- a/debootstrap.8
+++ b/debootstrap.8
@@ -137,11 +137,12 @@ Don't delete the /debootstrap directory in the target after completing the
installation.
.IP
.IP "\fB\-\-unpack\-tarball=FILE\fP"
-Acquire .debs from tarball FILE instead of downloading via http.
+Acquire .debs from gzipped tarball FILE (specified with absolute path)
+instead of downloading via http.
.IP
.IP "\fB\-\-make\-tarball=FILE\fP"
-Instead of bootstrapping, make a tarball (written to FILE) of the downloaded
-packages.
+Instead of bootstrapping, make a gzipped tarball (written to FILE) of the
+downloaded packages.
The resulting tarball may be passed to a later
.BR \-\-unpack\-tarball .
.IP

[Justin B Rye]

Post by Hideki Yamane
Could you review below messages in deboostrap manpage, please?

Looks good to me.

Post by Hideki Yamane

Here's a proposed patch for it.
diff --git a/debootstrap b/debootstrap
index 083473d..1d5d5c6 100755
--- a/debootstrap
+++ b/debootstrap
@@ -550,7 +550,7 @@ fi
if [ "$UNPACK_TARBALL" ]; then
if [ "${UNPACK_TARBALL#/}" = "$UNPACK_TARBALL" ]; then
- error 1 TARPATH "Tarball must be given a complete path"
+ error 1 TARPATH "Tarball must be given an absolute path"
fi
if [ "${UNPACK_TARBALL%.tar}" != "$UNPACK_TARBALL" ]; then
(cd "$TARGET" && tar -xf "$UNPACK_TARBALL")
diff --git a/debootstrap.8 b/debootstrap.8
index e802003..699f1fd 100644
--- a/debootstrap.8
+++ b/debootstrap.8
@@ -137,11 +137,12 @@ Don't delete the /debootstrap directory in the target after completing the
installation.
.IP
.IP "\fB\-\-unpack\-tarball=FILE\fP"
-Acquire .debs from tarball FILE instead of downloading via http.
+Acquire .debs from gzipped tarball FILE (specified with absolute path)
+instead of downloading via http.
.IP
.IP "\fB\-\-make\-tarball=FILE\fP"
-Instead of bootstrapping, make a tarball (written to FILE) of the downloaded
-packages.
+Instead of bootstrapping, make a gzipped tarball (written to FILE) of the
+downloaded packages.
The resulting tarball may be passed to a later
.BR \-\-unpack\-tarball .
.IP

If I was doing a pedantic review of every bit of debootstrap's
documentation and output I'd suggest replacing "http(s)" with
"HTTP(S)" throughout, but there's no point doing that just here.

[Hideki Yamane]

Hi,

On Tue, 3 Apr 2018 12:30:34 +0100

Post by Justin B Rye

Post by Hideki Yamane
Could you review below messages in deboostrap manpage, please?

Looks good to me.

Thanks!

Post by Justin B Rye
If I was doing a pedantic review of every bit of debootstrap's
documentation and output I'd suggest replacing "http(s)" with
"HTTP(S)" throughout, but there's no point doing that just here.

I can find only one "via http" word, as below. Is it okay?

diff --git a/debootstrap.8 b/debootstrap.8
index e802003..87e2ae1 100644
--- a/debootstrap.8
+++ b/debootstrap.8
@@ -137,7 +137,7 @@ Don't delete the /debootstrap directory in the target after completing the
installation.
.IP
.IP "\fB\-\-unpack\-tarball=FILE\fP"
-Acquire .debs from tarball FILE instead of downloading via http.
+Acquire .debs from tarball FILE instead of downloading via HTTP(S).
.IP
.IP "\fB\-\-make\-tarball=FILE\fP"
Instead of bootstrapping, make a tarball (written to FILE) of the downloaded

[Justin B Rye]

Post by Hideki Yamane

Post by Justin B Rye
If I was doing a pedantic review of every bit of debootstrap's
documentation and output I'd suggest replacing "http(s)" with
"HTTP(S)" throughout, but there's no point doing that just here.

I can find only one "via http" word, as below. Is it okay?

Well, I was saying "don't bother"! But it looks easier than I was
assuming.

Post by Hideki Yamane
diff --git a/debootstrap.8 b/debootstrap.8
index e802003..87e2ae1 100644
--- a/debootstrap.8
+++ b/debootstrap.8
@@ -137,7 +137,7 @@ Don't delete the /debootstrap directory in the target after completing the
installation.
.IP
.IP "\fB\-\-unpack\-tarball=FILE\fP"
-Acquire .debs from tarball FILE instead of downloading via http.
+Acquire .debs from tarball FILE instead of downloading via HTTP(S).

Yes, this is an improvement if it might use HTTPS, though not if it
will always use HTTP.

But you missed the equivalent text in the debootstrap usage message:

--unpack-tarball=T acquire .debs from a tarball instead of http
^^^^
(Elsewhere in the usage output it already uses uppercase.)

I notice one other mention of wrong-case "https" in the debootstrap
sources (apart from changelog mentions): "functions" has a "keyring()"
function with this output:

info KEYRING "Keyring file not available at %s; switching to https mirror %s" "$1" "$DEF_HTTPS_MIRROR"
^^^^^

[Hideki Yamane]

On Tue, 3 Apr 2018 13:14:15 +0100

Post by Justin B Rye
Yes, this is an improvement if it might use HTTPS, though not if it
will always use HTTP.

debootstrap work depends on mirror and it use both HTTP and HTTPS
by default.
Okay, I just looked at debootstrap.8 file. Fixed :)